[Mlir-commits] [mlir] [mlir][spirv] Update assembly format for Image operand types (PR #130758)

Jakub Kuderski llvmlistbot at llvm.org
Wed Mar 12 07:56:43 PDT 2025


================
@@ -115,7 +115,7 @@ def SPIRV_ImageDrefGatherOp : SPIRV_Op<"ImageDrefGather",
 
   let assemblyFormat = [{
     $sampled_image `,` $coordinate `,` $dref custom<ImageOperands>($image_operands) ( `(` $operand_arguments^ `)` )? attr-dict 
-    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ( `(` type($operand_arguments)^ `)` )?
+    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ` ` ( `(` type($operand_arguments)^ `)` )?
----------------
kuhar wrote:

IE having parens in the input portion of the op type seems to be the root cause of our issues here, and I'd prefer to drop them.

https://github.com/llvm/llvm-project/pull/130758


More information about the Mlir-commits mailing list