[Mlir-commits] [mlir] [mlir][spirv] Update assembly format for Image operand types (PR #130758)

Jakub Kuderski llvmlistbot at llvm.org
Wed Mar 12 07:55:24 PDT 2025


================
@@ -115,7 +115,7 @@ def SPIRV_ImageDrefGatherOp : SPIRV_Op<"ImageDrefGather",
 
   let assemblyFormat = [{
     $sampled_image `,` $coordinate `,` $dref custom<ImageOperands>($image_operands) ( `(` $operand_arguments^ `)` )? attr-dict 
-    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ( `(` type($operand_arguments)^ `)` )?
+    `:` type($sampled_image) `,` type($coordinate) `,` type($dref) ` ` ( `(` type($operand_arguments)^ `)` )?
----------------
kuhar wrote:

Instead of adding spaces to the format, could we start converging towards a common format with `T0, T1, T2 -> T3`? This won't make the grammar ambiguous, AFAICT.

https://github.com/llvm/llvm-project/pull/130758


More information about the Mlir-commits mailing list