[Mlir-commits] [mlir] [mlir][TOSA] Fix linalg lowering of depthwise conv2d (PR #130282)

Fri Mar 7 05:36:03 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `mlir` at step 10 "Add check check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/18467

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 10 (Add check check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Conversion/TosaToLinalg/tosa-to-linalg-named.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline="builtin.module(func.func(tosa-to-linalg-named))" /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -| /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/FileCheck /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
# executed command: /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt --verify-each --split-input-file '-pass-pipeline=builtin.module(func.func(tosa-to-linalg-named))' /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# .---command stderr------------
# | <unknown>:0: error: unexpected error: expected integer or index type
# | mlir-opt: /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/include/mlir/IR/StorageUniquerSupport.h:180: static ConcreteT mlir::detail::StorageUserBase<ConcreteT, BaseT, StorageT, UniquerT, Traits>::get(mlir::MLIRContext*, Args&& ...) [with Args = {mlir::Type&, const llvm::APInt&}; ConcreteT = mlir::IntegerAttr; BaseT = mlir::Attribute; StorageT = mlir::detail::IntegerAttrStorage; UniquerT = mlir::detail::AttributeUniquer; Traits = {mlir::TypedAttr::Trait}]: Assertion `succeeded( ConcreteT::verifyInvariants(getDefaultDiagnosticEmitFn(ctx), args...))' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
# | Stack dump:
# | 0.	Program arguments: /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline=builtin.module(func.func(tosa-to-linalg-named)) /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# |  #0 0x0000000001819e58 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x1819e58)
# |  #1 0x0000000001816db4 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
# |  #2 0x00007faf34fce910 __restore_rt (/lib64/libpthread.so.0+0x16910)
# |  #3 0x00007faf348fcd2b raise (/lib64/libc.so.6+0x4ad2b)
# |  #4 0x00007faf348fe3e5 abort (/lib64/libc.so.6+0x4c3e5)
# |  #5 0x00007faf348f4c6a __assert_fail_base (/lib64/libc.so.6+0x42c6a)
# |  #6 0x00007faf348f4cf2 (/lib64/libc.so.6+0x42cf2)
# |  #7 0x00000000042a3f27 mlir::IntegerAttr::get(mlir::Type, llvm::APInt const&) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x42a3f27)
# |  #8 0x0000000004287b47 mlir::Builder::getIntegerAttr(mlir::Type, long) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x4287b47)
# |  #9 0x000000000401067a (anonymous namespace)::DepthwiseConvConverter::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpAdaptor, mlir::ConversionPatternRewriter&) const TosaToLinalgNamed.cpp:0:0
# | #10 0x0000000004000420 mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpGenericAdaptor<llvm::ArrayRef<mlir::ValueRange>>, mlir::ConversionPatternRewriter&) const (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x4000420)
# | #11 0x000000000400157e mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::ValueRange>, mlir::ConversionPatternRewriter&) const (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x400157e)
# | #12 0x00000000041f173b mlir::ConversionPattern::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x41f173b)
# | #13 0x0000000007607a53 mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x7607a53)
# | #14 0x00000000041f4db1 (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*, mlir::ConversionPatternRewriter&) DialectConversion.cpp:0:0
# | #15 0x00000000041f5615 mlir::OperationConverter::convert(mlir::ConversionPatternRewriter&, mlir::Operation*) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x41f5615)
# | #16 0x00000000041f7c0b mlir::OperationConverter::convertOperations(llvm::ArrayRef<mlir::Operation*>) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x41f7c0b)
# | #17 0x00000000041f9fd1 mlir::applyFullConversion(mlir::Operation*, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x41f9fd1)
# | #18 0x0000000003fb345c (anonymous namespace)::TosaToLinalgNamed::runOnOperation() TosaToLinalgNamedPass.cpp:0:0
# | #19 0x000000000414bce1 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414bce1)
# | #20 0x000000000414c01a mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414c01a)
# | #21 0x000000000414c3f2 mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::'lambda'(mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo&)::operator()(mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo&) const Pass.cpp:0:0
# | #22 0x000000000414b2c5 mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414b2c5)
# | #23 0x000000000414bb33 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414bb33)
# | #24 0x000000000414cb53 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (.constprop.559) Pass.cpp:0:0
# | #25 0x000000000414d25f mlir::PassManager::run(mlir::Operation*) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414d25f)
# | #26 0x000000000413f317 performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
# | #27 0x000000000413fb7c processBuffer(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::MlirOptMainConfig const&, mlir::DialectRegistry&, llvm::ThreadPoolInterface*) MlirOptMain.cpp:0:0
# | #28 0x000000000413feb1 llvm::LogicalResult llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::'lambda'(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&) MlirOptMain.cpp:0:0
# | #29 0x00000000042452ed mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef)::'lambda'(llvm::StringRef)::operator()(llvm::StringRef) const ToolUtilities.cpp:0:0
# | #30 0x0000000004245e5e mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x4245e5e)
# | #31 0x0000000004138ffc mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x4138ffc)
# | #32 0x000000000413ffd7 mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x413ffd7)
# | #33 0x000000000414046b mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x414046b)
# | #34 0x0000000001746975 main (/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/bin/mlir-opt+0x1746975)
# | #35 0x00007faf348e724d __libc_start_main (/lib64/libc.so.6+0x3524d)
...

```

</details>

https://github.com/llvm/llvm-project/pull/130282