[Mlir-commits] [mlir] [mlir][TOSA] Fix linalg lowering of depthwise conv2d (PR #130282)

Fri Mar 7 05:34:02 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-s390x-linux` running on `systemz-1` while building `mlir` at step 6 "test-build-unified-tree-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/117/builds/7400

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Conversion/TosaToLinalg/tosa-to-linalg-named.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline="builtin.module(func.func(tosa-to-linalg-named))" /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -| /home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/FileCheck /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
# executed command: /home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt --verify-each --split-input-file '-pass-pipeline=builtin.module(func.func(tosa-to-linalg-named))' /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# .---command stderr------------
# | <unknown>:0: error: unexpected error: expected integer or index type
# | mlir-opt: /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/IR/StorageUniquerSupport.h:179: static ConcreteT mlir::detail::StorageUserBase<ConcreteT, BaseT, StorageT, UniquerT, Traits>::get(mlir::MLIRContext*, Args&& ...) [with Args = {mlir::Type&, const llvm::APInt&}; ConcreteT = mlir::IntegerAttr; BaseT = mlir::Attribute; StorageT = mlir::detail::IntegerAttrStorage; UniquerT = mlir::detail::AttributeUniquer; Traits = {mlir::TypedAttr::Trait}]: Assertion `succeeded( ConcreteT::verifyInvariants(getDefaultDiagnosticEmitFn(ctx), args...))' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
# | Stack dump:
# | 0.	Program arguments: /home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt --verify-each --split-input-file -pass-pipeline=builtin.module(func.func(tosa-to-linalg-named)) /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir -verify-diagnostics -o -
# |  #0 0x000002aa208eebd6 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x156ebd6)
# |  #1 0x000002aa208ebf56 llvm::sys::RunSignalHandlers() (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x156bf56)
# |  #2 0x000002aa208ec0f8 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
# |  #3 0x000003ffbbc7e480 (linux-vdso64.so.1+0x480)
# |  #4 0x000003ffbb598116 __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
# |  #5 0x000003ffbb548ac0 raise ./signal/../sysdeps/posix/raise.c:27:3
# |  #6 0x000003ffbb52a460 abort ./stdlib/abort.c:81:7
# |  #7 0x000003ffbb540188 __assert_fail_base ./assert/assert.c:91:7
# |  #8 0x000003ffbb5401fe (/lib/s390x-linux-gnu/libc.so.6+0x401fe)
# |  #9 0x000002aa23ff0d2c mlir::IntegerAttr::get(mlir::Type, llvm::APInt const&) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4c70d2c)
# | #10 0x000002aa23fc0f00 mlir::Builder::getIntegerAttr(mlir::Type, long) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4c40f00)
# | #11 0x000002aa23cddf46 (anonymous namespace)::DepthwiseConvConverter::matchAndRewrite(mlir::tosa::DepthwiseConv2DOp, mlir::tosa::DepthwiseConv2DOpAdaptor, mlir::ConversionPatternRewriter&) const TosaToLinalgNamed.cpp:0:0
# | #12 0x000002aa23ccef4e mlir::OpConversionPattern<mlir::tosa::DepthwiseConv2DOp>::matchAndRewrite(mlir::Operation*, llvm::ArrayRef<mlir::ValueRange>, mlir::ConversionPatternRewriter&) const (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x494ef4e)
# | #13 0x000002aa23efd4b8 mlir::ConversionPattern::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4b7d4b8)
# | #14 0x000002aa27104c02 mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref<bool (mlir::Pattern const&)>, llvm::function_ref<void (mlir::Pattern const&)>, llvm::function_ref<llvm::LogicalResult (mlir::Pattern const&)>) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x7d84c02)
# | #15 0x000002aa23f01b12 (anonymous namespace)::OperationLegalizer::legalize(mlir::Operation*, mlir::ConversionPatternRewriter&) DialectConversion.cpp:0:0
# | #16 0x000002aa23f0206e mlir::OperationConverter::convert(mlir::ConversionPatternRewriter&, mlir::Operation*) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4b8206e)
# | #17 0x000002aa23f05aa6 mlir::OperationConverter::convertOperations(llvm::ArrayRef<mlir::Operation*>) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4b85aa6)
# | #18 0x000002aa23f07fd8 mlir::applyFullConversion(mlir::Operation*, mlir::ConversionTarget const&, mlir::FrozenRewritePatternSet const&, mlir::ConversionConfig) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4b87fd8)
# | #19 0x000002aa23c75e06 (anonymous namespace)::TosaToLinalgNamed::runOnOperation() TosaToLinalgNamedPass.cpp:0:0
# | #20 0x000002aa23e49e9c mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4ac9e9c)
# | #21 0x000002aa23e4a384 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4aca384)
# | #22 0x000002aa23e4a984 mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::'lambda'(mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo&)::operator()(mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool)::OpPMInfo&) const Pass.cpp:0:0
# | #23 0x000002aa23e49492 mlir::detail::OpToOpPassAdaptor::runOnOperationAsyncImpl(bool) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4ac9492)
# | #24 0x000002aa23e49cc0 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4ac9cc0)
# | #25 0x000002aa23e4a384 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4aca384)
# | #26 0x000002aa23e4b718 mlir::PassManager::run(mlir::Operation*) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4acb718)
# | #27 0x000002aa23e39886 performActions(llvm::raw_ostream&, std::shared_ptr<llvm::SourceMgr> const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
# | #28 0x000002aa23e3a198 processBuffer(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::MlirOptMainConfig const&, mlir::DialectRegistry&, llvm::ThreadPoolInterface*) MlirOptMain.cpp:0:0
# | #29 0x000002aa23e3a48c llvm::LogicalResult llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>::callback_fn<mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::'lambda'(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>(long, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&) MlirOptMain.cpp:0:0
# | #30 0x000002aa23f6366c mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef)::'lambda'(llvm::StringRef)::operator()(llvm::StringRef) const ToolUtilities.cpp:0:0
# | #31 0x000002aa23f63ff2 mlir::splitAndProcessBuffer(std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::function_ref<llvm::LogicalResult (std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4be3ff2)
# | #32 0x000002aa23e32272 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr<llvm::MemoryBuffer, std::default_delete<llvm::MemoryBuffer>>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4ab2272)
# | #33 0x000002aa23e3a5fc mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4aba5fc)
# | #34 0x000002aa23e3ab02 mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x4abab02)
# | #35 0x000002aa20824e60 main (/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/bin/mlir-opt+0x14a4e60)
...

```

</details>

https://github.com/llvm/llvm-project/pull/130282