[Mlir-commits] [mlir] [mlir][memref] Add a new `ReifyResultShapes` pass (PR #145927)

Nicolas Vasilache llvmlistbot at llvm.org
Fri Jun 27 00:56:07 PDT 2025


nicolasvasilache wrote:

> Ok, maybe I misread what it the intent was and got thrown off by the use of the `ReifyRankedShapedTypeOpInterface`. (the reify was meant to say "generate the shape of the output" implicitly saying generate the code for `tensor.dim <result>, <dim>`.).

There is no need to limit the interface to only exist in conjunction with `tensor.dim` ops, see my explanation here https://github.com/llvm/llvm-project/pull/145732#issuecomment-3012048686

I also don't understand "implicitly saying generate the code for `tensor.dim <result>, <dim>`": this is really a shape question, which may or may not involve `tensor.dim` ops. The more we fold away such ops the better to obtain static shapes.

Happy to rename the functionality if that is what causes hiccups (naming is still hard in 2025).

https://github.com/llvm/llvm-project/pull/145927


More information about the Mlir-commits mailing list