[Mlir-commits] [mlir] [mlir][memref] Add a new `ReifyResultShapes` pass (PR #145927)

[Nicolas Vasilache]

nicolasvasilache wrote:

> We need to add a pattern by itself that is similar to what is done for `tensor.extract_slice` [here](https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp#L2724). Sorry I think you intended to do that from the get go, but I was thrown off by the `ReifyRankedShapedTypeOpInterface` angle.

Well, the `tensor.extract_slice` points to a canonicalization pattern but in https://github.com/llvm/llvm-project/pull/145732 you write """Bundling that in a canonicalization that allows no control of what is run is a huge flaw that in my view we should work ourselves out of."""
So which is it ? :)

https://github.com/llvm/llvm-project/pull/145927