[Mlir-commits] [mlir] [mlir][vector][memref] Add `alignment` attribute to memory access ops (PR #144344)

[Andrzej Warzyński]

banach-space wrote:

> The alignment attribute is general enough to subsume use-vector-alignment -- we can write a simple pass to populate alignment attributes based on the vector types. So in this sense, we may be able to reduce feature duplication in the future.

> I'd argue for removing it in favor of some flavor of vector-declare-natural-alignment transform over the vector dialect to reduce that same redundancy.

+1 Lets make sure that there is a clear TODO to that end.

Btw, there is more Ops that access memory:
* `vector.gather` + `vector.scatter`
* `vector.transfer_read` + `vector.transfer_write`
* `vector.compressstore` + `vector.expandload`

What about these?

https://github.com/llvm/llvm-project/pull/144344