[Mlir-commits] [mlir] [mlir][vector][memref] Add `alignment` attribute to memory access ops (PR #144344)

[Krzysztof Drewniak]

krzysz00 wrote:

Yeah, I remember when landing `--convert-vector-to-llvm='use-vector-alignment=1` I had the sense that it was a temporary solution to work around the fact that we couldn't put `alignment` on vector loads/stores.

I'd argue for removing it in favor of some flavor of `vector-declare-natural-alignment` transform over the vector dialect to reduce that same redundancy.

`memref.assume_alignment` is a rather weird op that, as far as I can tell, exists to allow backends that try to reason about pointer alignment to not stumble over the mysterious pointer-out-of-nowhere that can exist inside memrefs's base.

https://github.com/llvm/llvm-project/pull/144344