[Mlir-commits] [mlir] Revert "Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags" (PR #142318)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Jun 1 13:45:45 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Vitaly Buka (vitalybuka)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->142210
This is not enough, see #<!-- -->141664
---
Full diff: https://github.com/llvm/llvm-project/pull/142318.diff
1 Files Affected:
- (modified) mlir/unittests/IR/OperationSupportTest.cpp (+2-2)
``````````diff
diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index 18ee9d71cb9fc..b18512817969e 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
auto req2 = b.getI32IntegerAttr(60);
Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
b.getUnknownLoc(), req2, nullptr, nullptr, req2);
+ EXPECT_NE(getHash(op1, OperationEquivalence::None),
+ getHash(op2, OperationEquivalence::None));
EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
- EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
- getHash(opWithProperty2, OperationEquivalence::None));
opWithProperty1->destroy();
opWithProperty2->destroy();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/142318
More information about the Mlir-commits
mailing list