[Mlir-commits] [mlir] 002c0ab - Revert "Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags" (#142318)

[llvmlistbot at llvm.org]

Author: Vitaly Buka
Date: 2025-06-01T13:45:32-07:00
New Revision: 002c0abcd85c50d3f68a3d29d624ef21b0ec0c9a

URL: https://github.com/llvm/llvm-project/commit/002c0abcd85c50d3f68a3d29d624ef21b0ec0c9a
DIFF: https://github.com/llvm/llvm-project/commit/002c0abcd85c50d3f68a3d29d624ef21b0ec0c9a.diff

LOG: Revert "Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags" (#142318)

Reverts llvm/llvm-project#142210

This is not enough, see #141664

Added: 
    

Modified: 
    mlir/unittests/IR/OperationSupportTest.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index 18ee9d71cb9fc..b18512817969e 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
   auto req2 = b.getI32IntegerAttr(60);
   Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
       b.getUnknownLoc(), req2, nullptr, nullptr, req2);
+  EXPECT_NE(getHash(op1, OperationEquivalence::None),
+            getHash(op2, OperationEquivalence::None));
   EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
             getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
-  EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
-            getHash(opWithProperty2, OperationEquivalence::None));
   opWithProperty1->destroy();
   opWithProperty2->destroy();
 }