[Mlir-commits] [mlir] [mlir][vector] Canonicalize broadcast of shape_cast (PR #150523)

[James Newling]

https://github.com/newling commented:

I don't think this is always valid?

(2,1) -> shape_cast -> (1,2) -> broadcast (2,2)

and 

(2,1) -> broadcast (2,2) 

are different. 

Example. If input is [[5], [6]]. then first one's output is [[5, 6], [5, 6]] but second one's is [[5, 5], [6, 6]]. 





https://github.com/llvm/llvm-project/pull/150523