[Mlir-commits] [mlir] [mlir][vector] Canonicalize broadcast of shape_cast (PR #150523)

[James Newling]

newling wrote:

Can you reuse isBroadcastLike https://github.com/llvm/llvm-project/blob/2571924ad6b8ca4a914ef613677cc41079224428/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L1712 ?

General rule is that is something can be a folder, it should be (i.e. on BroadcastOp::fold) https://mlir.llvm.org/docs/Canonicalization/#when-to-use-the-fold-method-vs-rewriterpatterns-for-canonicalizations

https://github.com/llvm/llvm-project/pull/150523