[Mlir-commits] [mlir] [mlir][ODS] Fix TableGen for AttrOrTypeDef::hasStorageCustomConstructor (PR #147957)

[Andrei Golubev]

================
@@ -668,10 +668,10 @@ void DefGen::emitHashKey() {
 }
 
 void DefGen::emitConstruct() {
-  Method *construct = storageCls->addMethod<Method::Inline>(
+  Method *construct = storageCls->addMethod(
       strfmt("{0} *", def.getStorageClassName()), "construct",
       def.hasStorageCustomConstructor() ? Method::StaticDeclaration
-                                        : Method::Static,
+                                        : Method::StaticInline,
----------------
andrey-golubev wrote:

apparently, this seems to be the only place within the upstream/main right now. anyway, pushed this as a separate PR - https://github.com/llvm/llvm-project/pull/147979 (perhaps we need to figure out how we want to report the errors - only in debug mode or somehow differently).

https://github.com/llvm/llvm-project/pull/147957