[Mlir-commits] [mlir] [mlir][ODS] Fix TableGen for AttrOrTypeDef::hasStorageCustomConstructor (PR #147957)

[Andrei Golubev]

================
@@ -668,10 +668,10 @@ void DefGen::emitHashKey() {
 }
 
 void DefGen::emitConstruct() {
-  Method *construct = storageCls->addMethod<Method::Inline>(
+  Method *construct = storageCls->addMethod(
       strfmt("{0} *", def.getStorageClassName()), "construct",
       def.hasStorageCustomConstructor() ? Method::StaticDeclaration
-                                        : Method::Static,
+                                        : Method::StaticInline,
----------------
andrey-golubev wrote:

generally, i think it should work. i'll try locally. i guess if there's a bunch of failures, i'd prefer to put it into a separate patch.

btw, is it safe to assume then that `Declaration` implies "no definition"?

> `Method::Inline` and `StaticDeclaration`

I guess you meant between `Inline` and `Declaration`? `static` is a separate property I imagine (e.g. same reasoning would apply to non-static methods also).

https://github.com/llvm/llvm-project/pull/147957