[Mlir-commits] [mlir] [MLIR] emitc: Add emitc translation unit op (PR #123298)

Matthias Gehre llvmlistbot at llvm.org
Fri Jan 17 02:13:49 PST 2025


mgehre-amd wrote:

> > This feature is opt-in; by default,
> > `mlir-translate` will continue to emit the whole module.
> 
> Can you reformat this line, please; and maybe I'm reading this wrong, but I expected the code to emit all TUs if not filtered by the `translation-unit-id` flag. Should we reformulate to something like `mlir-translate will continue to emit operations defined outside of tu operations`?

I have reformulated the description. Does that sound better?

https://github.com/llvm/llvm-project/pull/123298


More information about the Mlir-commits mailing list