[Mlir-commits] [mlir] [MLIR] emitc: Add emitc translation unit op (PR #123298)

Matthias Gehre llvmlistbot at llvm.org
Fri Jan 17 02:13:30 PST 2025


mgehre-amd wrote:

> Quick question before having a change to take a deeper look. Would it make sense to introduce an `emitc.module` instead of an `emitc.tu`? Only referring to the naming here.

I don't mind the naming. In practice, we use a structure like
```
module {
  emitc.tu {
   func ...
  }
  emitc.tu {
   func ...
  }
}
```
and I liked that the `emitc.tu` was visually different from the enclosing `module`. But both is fine for me.

https://github.com/llvm/llvm-project/pull/123298


More information about the Mlir-commits mailing list