[Mlir-commits] [mlir] [TOSA] Change PadOp padding to tosa.shape (PR #123133)

[Georgios Pinitas]

================
@@ -39,6 +39,8 @@ ParseResult parseTypeOrAttr(OpAsmParser &parser, TypeAttr &typeAttr,
 void printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
                      Attribute attr);
 
+bool collectShapeValue(Operation *op, llvm::SmallVector<int64_t> &newShape);
----------------
GeorgeARM wrote:

> CollectShapeValue was meant to calculate a new/result shape value by collecting previous shape value information by backtracking the callers

I might have missed the backtracking code. When I checked the implementation it seems to just extract the values from the attribute back to a vector.

https://github.com/llvm/llvm-project/pull/123133