[Mlir-commits] [mlir] [TOSA] Change PadOp padding to tosa.shape (PR #123133)

[Won Jong Jeon]

================
@@ -39,6 +39,8 @@ ParseResult parseTypeOrAttr(OpAsmParser &parser, TypeAttr &typeAttr,
 void printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
                      Attribute attr);
 
+bool collectShapeValue(Operation *op, llvm::SmallVector<int64_t> &newShape);
----------------
wonjeon wrote:

@GeorgeARM Thanks for your comments.

- `CollectShapeValue` was meant to calculate a new/result shape value by collecting previous shape value information by backtracking the callers of the code. Agree that the name `ExtractConstShapeValue` seems cleaner.
- `new_shape` is the name of the output variable of this function. Probably `result_shape` would sound better?
- Agree to move this function to Utils.

https://github.com/llvm/llvm-project/pull/123133