[Mlir-commits] [mlir] [MLIR] Implement emulation of static indexing subbyte type vector stores (PR #115922)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue Jan 14 09:16:07 PST 2025


================
@@ -336,30 +442,143 @@ struct ConvertVectorStore final : OpConversionPattern<vector::StoreOp> {
     // vector.store %bitcast, %alloc[%linear_index] : memref<16xi8>,
     // vector<4xi8>
 
-    auto origElements = op.getValueToStore().getType().getNumElements();
-    if (origElements % scale != 0)
-      return failure();
+    auto origElements = valueToStore.getType().getNumElements();
+    bool isUnalignedEmulation = origElements % numSrcElemsPerDest != 0;
----------------
banach-space wrote:

[nit] `isAlignedEmulation` would be shorter and a bit intuitive to me.

https://github.com/llvm/llvm-project/pull/115922


More information about the Mlir-commits mailing list