[Mlir-commits] [mlir] Remove StandaloneExtensionPybind11.cpp FT update as does not work with python 3.8 and old pybind11 (PR #122697)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jan 13 03:54:33 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: vfdev (vfdev-5)

<details>
<summary>Changes</summary>

Description:
- Remove StandaloneExtensionPybind11.cpp FT update as does not work with python 3.8 and old pybind11

This should also fix the failing toy.test: https://github.com/llvm/llvm-project/pull/122684#issuecomment-2586802692

cc @<!-- -->jpienaar 

---
Full diff: https://github.com/llvm/llvm-project/pull/122697.diff


1 Files Affected:

- (modified) mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp (+1-3) 


``````````diff
diff --git a/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp b/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
index dd3c4c2945cca8..397db4c20e7432 100644
--- a/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
+++ b/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
@@ -12,11 +12,9 @@
 #include "Standalone-c/Dialects.h"
 #include "mlir/Bindings/Python/PybindAdaptors.h"
 
-namespace py = pybind11;
-
 using namespace mlir::python::adaptors;
 
-PYBIND11_MODULE(_standaloneDialectsPybind11, m, py::mod_gil_not_used()) {
+PYBIND11_MODULE(_standaloneDialectsPybind11, m) {
   //===--------------------------------------------------------------------===//
   // standalone dialect
   //===--------------------------------------------------------------------===//

``````````

</details>


https://github.com/llvm/llvm-project/pull/122697


More information about the Mlir-commits mailing list