[Mlir-commits] [mlir] Remove StandaloneExtensionPybind11.cpp FT update as does not work with python 3.8 and old pybind11 (PR #122697)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jan 13 03:53:56 PST 2025


https://github.com/vfdev-5 created https://github.com/llvm/llvm-project/pull/122697

Description:
- Remove StandaloneExtensionPybind11.cpp FT update as does not work with python 3.8 and old pybind11

This should also fix the failing toy.test: https://github.com/llvm/llvm-project/pull/122684#issuecomment-2586802692

cc @jpienaar 

>From 078b7a114f650e06dce2b37ccae1ad98dcc56f26 Mon Sep 17 00:00:00 2001
From: vfdev-5 <vfdev.5 at gmail.com>
Date: Mon, 13 Jan 2025 12:51:14 +0100
Subject: [PATCH] Remove StandaloneExtensionPybind11.cpp FT update as does not
 work with python 3.8 and old pybind11

---
 .../standalone/python/StandaloneExtensionPybind11.cpp         | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp b/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
index dd3c4c2945cca8..397db4c20e7432 100644
--- a/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
+++ b/mlir/examples/standalone/python/StandaloneExtensionPybind11.cpp
@@ -12,11 +12,9 @@
 #include "Standalone-c/Dialects.h"
 #include "mlir/Bindings/Python/PybindAdaptors.h"
 
-namespace py = pybind11;
-
 using namespace mlir::python::adaptors;
 
-PYBIND11_MODULE(_standaloneDialectsPybind11, m, py::mod_gil_not_used()) {
+PYBIND11_MODULE(_standaloneDialectsPybind11, m) {
   //===--------------------------------------------------------------------===//
   // standalone dialect
   //===--------------------------------------------------------------------===//



More information about the Mlir-commits mailing list