[Mlir-commits] [mlir] [mlir] Refactor ConvertVectorToLLVMPass options (PR #128219)

[Andrzej Warzyński]

banach-space wrote:

> My point was that we can s/convert-vector-to-llvm/convert-vector-to-llvm="vector-contract-lowering=, ..." for all the existing tests and explicitly add the default enum values for the new options that this PR is adding.

If these are "defaults" then adding them to `-convert-vector-to-llvm` should not be required, right? As in, that's the default values we are already using today:
https://github.com/llvm/llvm-project/blob/60cc3af0d93ecb8bfc9d6bebc6cbc395df3bb4b6/mlir/include/mlir/Dialect/Vector/Transforms/VectorTransforms.h#L32-L63

Perhaps just update "test-seriasable.mlir" so that it verifies that the intended defaults are indeed used. And then, add a  separate `RUN` line where the defaults are overriden with some other values?

https://github.com/llvm/llvm-project/pull/128219