[Mlir-commits] [mlir] [mlir] Refactor ConvertVectorToLLVMPass options (PR #128219)

[Diego Caballero]

dcaballe wrote:

I think `test-serialisable.mlir` is a great way to test the CL API without actually testing the underlying transformations. We should add more `RUN` rules there to check all the enum values for the new options. That should good coverage.

>> Would it be acceptable to add the default enum values to tests already using this pass and also add more flag combinations to the dump pipeline test?
>
> I'm not sure I follow ...

My point was that we can `s/convert-vector-to-llvm/convert-vector-to-llvm="vector-contract-lowering=, ..."` for all the existing tests and explicitly add the default enum values for the new options that this PR is adding. That would at least test some enum values of the CL API without testing the actual conversion functionality. I wouldn't go with anything that entails adding more `CHECK` rules as this is out of scope for this PR.



https://github.com/llvm/llvm-project/pull/128219