[Mlir-commits] [mlir] [MLIR][DLTI] Add mangling style (PR #125875)

[Rolf Morel]

================
@@ -49,6 +49,9 @@ def DLTI_Dialect : Dialect {
     constexpr const static ::llvm::StringLiteral
     kDataLayoutEndiannessLittle = "little";
 
+    constexpr const static ::llvm::StringLiteral
+    kDataLayoutManglingStyleKey = "dlti.mangling_style";
----------------
rolfmorel wrote:

Related to @joker-eph's comment above: is this "mangling style" supposed to correspond to a property from LLVM's Data Layout?

As you are parsing the "m" key in the Data Layout string, I would expect that you are wanting to represent the property that is named "mangling mode" in LLVM's Data Layout. See [here](https://github.com/llvm/llvm-project/blob/d867988cd9b0f8ea31e7dd9f995e341c9d5d8157/llvm/lib/IR/DataLayout.cpp#L570) and [here](https://github.com/llvm/llvm-project/blob/6543bd718e6a4e4d6a8473b478f8a46d3eb1562a/llvm/include/llvm/IR/DataLayout.h#L103-113).

Some elaboration on what property is meant - here on the PR and in doc strings - would be appreciated.

https://github.com/llvm/llvm-project/pull/125875