[Mlir-commits] [mlir] [MLIR][DLTI] Add mangling style (PR #125875)

[Rolf Morel]

https://github.com/rolfmorel commented:

Just two comments:

1. is this concerning the "mangling mode" property from LLVM's Data Layout? If so, why not reuse that name?

2. As @rengolin notes, there's considerable overlap in what these files are achieving (e.g. parsing of the data layout string) and what's already available in LLVM proper. While this PR is clearly continuing on a road previously forged, it would be good for us to step back and see if there's a simpler and cleaner way of obtaining and exposing this information, reusing available infrastructure where possible. 
   -  One approach @rengolin and I have been discussing is to automatically derive all Data Layout attributes (and TTI attributes etc.) from target triple+cpu+feature flags strings, by means of, e.g., the TargetMachine infrastructure in LLVM. One of the advantages would be it being more straightforward to stay in sync with the properties that LLVM provides. There are a couple of things to still work out regarding this approach though...

Point 2 is not meant to block this PR - instead it's meant to initiate discussion on how we can rely more on what LLVM is already providing and simplifying the code involved in exposing Data Layout info and the like.

https://github.com/llvm/llvm-project/pull/125875