[Mlir-commits] [llvm] [mlir] [MLIR][OpenMP] Use correct DebugLoc in target construct callbacks. (PR #125106)

[Abid Qadeer]

abidh wrote:

> Thanks Abid! I have one comment: is it possible to add a lit test? My issue with unit testing this is that the unit test mimics the changes in the actual code so if either go out of sync the changes intented by the PR won't be properly tested anymore. A lit test that triggers the bug will be a better guarantee for triggering a regression.

Thanks for having a look. As I mentioned, I noticed this issue while working on on #125088. I could not include a lit test in this PR because we hit the issue that is mentioned in #125088 first. I have a lit test ready with the fix for #125088 that also tests this behavior or I could open a separate PR once the fix for #125088 is merged to include a lit this for this change.

https://github.com/llvm/llvm-project/pull/125106