[Mlir-commits] [llvm] [mlir] [MLIR][OpenMP] Use correct DebugLoc in target construct callbacks. (PR #125106)
Kareem Ergawy
llvmlistbot at llvm.org
Mon Feb 3 01:44:22 PST 2025
ergawy wrote:
Thanks Abid! I have one comment: is it possible to add a lit test? My issue with unit testing this is that the unit test mimics the changes in the actual code so if either go out of sync the changes intented by the PR won't be properly tested anymore. A lit test that triggers the bug will be a better guarantee for triggering a regression.
https://github.com/llvm/llvm-project/pull/125106
More information about the Mlir-commits
mailing list