[Mlir-commits] [mlir] [mlir][dataflow] Add visitBranchPropertyArgument API to SparseDataFlowAnalysis and apply it in LivenessAnalysis/RemoveDeadValues/IntegerRangeAnalysis (PR #169816)

[Oleksandr Alex Zinenko]

================
@@ -320,11 +335,27 @@ void AbstractSparseForwardDataFlowAnalysis::visitRegionSuccessors(
         if (!inputs.empty())
           firstIndex = cast<BlockArgument>(inputs.front()).getArgNumber();
         Region *region = point->getBlock()->getParent();
+        auto nonControlFlowArguments =
+            region->getArguments().slice(firstIndex, inputs.size());
----------------
ftynse wrote:

This is confusing. ` ValueRange inputs = predecessors->getSuccessorInputs(op);` contains the list of values that are forwarded to the successor. In other words, values that _are control flow arguments_, the exact opposite of what the name indicates.

https://github.com/llvm/llvm-project/pull/169816