[Mlir-commits] [mlir] [mlir][dataflow] Add visitBranchPropertyArgument API to SparseDataFlowAnalysis and apply it in LivenessAnalysis/RemoveDeadValues/IntegerRangeAnalysis (PR #169816)

[Oleksandr Alex Zinenko]

================
@@ -217,6 +217,10 @@ class AbstractSparseForwardDataFlowAnalysis : public DataFlowAnalysis {
       Operation *op, const RegionSuccessor &successor,
       ArrayRef<AbstractSparseLattice *> argLattices, unsigned firstIndex) = 0;
 
+  virtual void visitBranchPropertyArgumentImpl(
----------------
ftynse wrote:

This needs a documentation comment.

Also, please please please don't invent new terminology, especially with the word "property". It is already highly confusing between attributes, properties and non-attribute properties. Just call it what it is, even if it is lengthy. What I especially can't grasp immediately is how is this different from `visitNonControlFlowArguments`.

https://github.com/llvm/llvm-project/pull/169816