[Mlir-commits] [mlir] [MLIR][GPU] Support grid constant, byval, byref on gpu.func (PR #172037)

[Krzysztof Drewniak]

================
@@ -369,7 +370,10 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
     }
 
     if (lowersToPointer) {
+      copyPointerAttribute(mlir::NVVM::NVVMDialect::getGridConstantAttrName());
----------------
krzysz00 wrote:

Wait, what's that got to with "just transparently copy the annotations"? What attribute verifier?

(Also, enough GPU compilation flows - ex. Triton - don't use `gpu.func` that actually checking for `gpu.func` is something I'd oppose)

https://github.com/llvm/llvm-project/pull/172037