[Mlir-commits] [mlir] [MLIR][GPU] Support grid constant, byval, byref on gpu.func (PR #172037)

[Mehdi Amini]

================
@@ -369,7 +370,10 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
     }
 
     if (lowersToPointer) {
+      copyPointerAttribute(mlir::NVVM::NVVMDialect::getGridConstantAttrName());
----------------
joker-eph wrote:

> I don't see the issue with just landing "llvm pointers, integers, and anything else with a trivial API just gets its argument attributes copied"

An attribute verifier could just check that it is attached to a gpu.func for example.

https://github.com/llvm/llvm-project/pull/172037