[Mlir-commits] [mlir] [mlir][AMX] Memory effects to amx.tile_zero (PR #155403)

[Adam Siemieniuk]

adam-smnk wrote:

> > > Can you add a test? Runs CSE and make sure the tile_zero doesn't get removed.
> > 
> > 
> > Not sure if that in particular needs testing. It's a generic feature of memory effect traits. To really test the desired behavior, we'd need to pipe it all the way to `llc` IMO.
> 
> Just that IR on the description through `cse` and show that only three are left?

Fair enough, doesn't hurt to have extra coverage.

@arun-thmn Could you add a new test file under `test/Dialect/AMX` for this side effect testing?
For consistency, `tile_load` should also have `MemWrite` to model side effect of writing into an AMX tile.
And the op descriptions should mention the updated semantics.

https://github.com/llvm/llvm-project/pull/155403