[Mlir-commits] [mlir] [MLIR][LLVMIR][DLTI] Pass to update #llvm.target's features per relevant backend (PR #154938)

[Mehdi Amini]

================
@@ -561,7 +561,7 @@ def LLVM_TargetAttrInterface
     >,
     InterfaceMethod<
       /*description=*/"Returns the target features as a string.",
-      /*retTy=*/"StringAttr",
+      /*retTy=*/"LLVM::TargetFeaturesAttr",
----------------
joker-eph wrote:

I'm not sure that the split you're doing to break the cyclic dependency is scalable. 
What we've done in other dialects instead is returning an Attribute and documenting that is would be always an `TargetFeaturesAttr` attribute .

https://github.com/llvm/llvm-project/pull/154938