[Mlir-commits] [mlir] [MLIR][LLVMIR][DLTI] Pass to update #llvm.target's features per relevant backend (PR #154938)

Mehdi Amini llvmlistbot at llvm.org
Sat Aug 23 07:47:24 PDT 2025


================
@@ -403,6 +403,20 @@ ModuleFlagAttr::verify(function_ref<InFlightDiagnostic()> emitError,
                      << key << "'";
 }
 
+FailureOr<Attribute> TargetFeaturesAttr::query(DataLayoutEntryKey key) {
+  if (auto stringKey = dyn_cast<StringAttr>(key)) {
----------------
joker-eph wrote:

```suggestion
  auto stringKey = dyn_cast<StringAttr>(key));
  if (!stringKey) return failure();
```

Nit: early return :)


https://github.com/llvm/llvm-project/pull/154938


More information about the Mlir-commits mailing list