[Mlir-commits] [mlir] [mlir][vector] Support multi-dimensional vectors in VectorFromElementsLowering (PR #151175)

[Andrzej Warzyński]

banach-space wrote:

> The idea is to have a vector-to-vector lowering [here](https://github.com/llvm/llvm-project/blob/193995d5a21dc8b923e19d9370aa8e1f374cd940/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp#L80), and to keep the actual `vector-to-llvm` conversion simple and restricted to already 'lowered' vector ops.

Keeping `vector-to-llvm` simple makes a lot of sense. Expanding `populateVectorShapeCastLoweringPatterns` (or creating patterns that inject `vector.shape_cast` and then leveraging `populateVectorShapeCastLoweringPatterns`) less so - wouldn't we be simply shifting the complexity within `vector-to-llvm` (as opposed to making it simpler)?

https://github.com/llvm/llvm-project/pull/151175