[Mlir-commits] [mlir] [mlir][vector] Support multi-dimensional vectors in VectorFromElementsLowering (PR #151175)

[James Newling]

newling wrote:

The idea is to have a vector-to-vector lowering [here](https://github.com/llvm/llvm-project/blob/193995d5a21dc8b923e19d9370aa8e1f374cd940/mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp#L80), and to keep the actual vector-to-llvm conversion simple and restricted to already 'lowered' vector ops. 

So I guess the request is to implement a function `populateVectorFromElementsOpLoweringPatterns`. Or my suggestion was to add a pattern there to split a rank-D from_elements op into a rank-1 from_elements op preceded by a shape_cast, and then `populateVectorShapeCastLoweringPatterns` will kick in and generate the inserts/extracts.  



https://github.com/llvm/llvm-project/pull/151175