[Mlir-commits] [mlir] [MLIR][Tensor] Remove FoldDimOf[Expand|Collapse]Shape Pattern (PR #134219)

[Mehdi Amini]

joker-eph wrote:

> Basically this pattern should never have been part of canonicalization,

Can you elaborate on why? You're stating a fact, but as I mentioned before, while you may very well be right (I don't know), it would be helpful if you could make the reasoning behind this explicit.

> . Blocking changes without providing guidance of next steps is not a very productive position to take.

Sorry if you feel that way, I believe I provided next steps quite a few times above, you just seem to have missed it maybe?
For example I wrote this that you didn't follow up on (unless I missed it?):

> Maybe an example showing the effect of this canonicalization pattern that shouldn't be a canonicalization?

https://github.com/llvm/llvm-project/pull/134219