[Mlir-commits] [mlir] [MLIR][Tensor] Remove FoldDimOf[Expand|Collapse]Shape Pattern (PR #134219)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > > > These pattern are also wrong
> > > > Wrong how?
> > > > Wrong cause they are crashing.
> 
> OK, we had a vocabulary mismatch here, "wrong" confused me, thanks for clarifying what you meant.
> 
> > So I think we dont even need to get into canonicalization vs. not discussion.
> 
> You want to remove something done in canonicalization to make it not part of canonicalization: so while I sympathize, I don't quite see how you can avoid the conversation.

Let me understand what you are suggesting. Basically this pattern should never have been part of canonicalization, but it was. It is an outlier w.r.t to the designated way in tree for resolution of `tensor.dim` operations, and you want to "fix" this pattern to do exactly what the other pattern does. I dont see how that is a reasonable outcome here. I suggest you provide concrete details of how you want to proceed here. Blocking changes without providing guidance of next steps is not a very productive position to take.

https://github.com/llvm/llvm-project/pull/134219