[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

[Andrzej Warzyński]

================
@@ -3627,6 +3635,7 @@ struct Conv1DGenerator
   int strideW, dilationW;
   Value lhsShaped, rhsShaped, resShaped;
   ShapedType lhsShapedType, rhsShapedType, resShapedType;
+  std::optional<vector::CombiningKind> maybeKind;
----------------
banach-space wrote:

Hm, are there any convs without reductions? IIUC, all convs include a reduction, so this could be defined as:
```cpp
vector::CombiningKind convReductionKind;
```

Or sth similar (the key thing is to skip `std::optional`)

https://github.com/llvm/llvm-project/pull/109480