[Mlir-commits] [mlir] [mlir] [scf] fix crash when conversion from scf to control flow (PR #107221)

[donald chen]

cxy-1993 wrote:

> `SCFToControlFlow` are RewritePatterns. These should not even be used in a dialect conversion. `getBody()->getTerminator()` is also not safe to use in a dialect conversion as you pointed out. So there are multiple issues with this code. But let's merge this, as it at least improves the situation a little bit.

Thanks for the context!

 However, I don't quite understand the statement that rewrite patterns cannot be used in dialect conversion. Isn't the conversion from scf to controlflow a dialect conversion, and what is the definition of dialect conversion? Are you suggesting that we should be cautious about using partial conversion?

https://github.com/llvm/llvm-project/pull/107221