[Mlir-commits] [mlir] [mlir] [scf] fix crash when conversion from scf to control flow (PR #107221)

Matthias Springer llvmlistbot at llvm.org
Thu Sep 5 01:36:22 PDT 2024


https://github.com/matthias-springer approved this pull request.

`SCFToControlFlow` are RewritePatterns. These should not even be used in a dialect conversion. `getBody()->getTerminator()` is also not safe to use in a dialect conversion as you pointed out. So there are multiple issues with this code. But let's merge this, as it at least improves the situation a little bit.


https://github.com/llvm/llvm-project/pull/107221


More information about the Mlir-commits mailing list