[Mlir-commits] [mlir] [MLIR][DLTI] Pretty parsing and printing for DLTI attrs (PR #113365)

Christian Ulmann llvmlistbot at llvm.org
Wed Oct 23 02:12:45 PDT 2024


================
@@ -28,6 +29,123 @@ using namespace mlir;
 
 #define DEBUG_TYPE "dlti"
 
+//===----------------------------------------------------------------------===//
+// parsing
+//===----------------------------------------------------------------------===//
+
+static ParseResult parseKeyValuePair(AsmParser &parser,
----------------
Dinistro wrote:

Nit: A small comment would be nice for all the functions. I'm aware that this was not applied to other functions in this file, but we learned that having lacking comments can lead to substantial issues down the road.

https://github.com/llvm/llvm-project/pull/113365


More information about the Mlir-commits mailing list