[Mlir-commits] [mlir] [MLIR][DLTI] Pretty parsing and printing for DLTI attrs (PR #113365)
Christian Ulmann
llvmlistbot at llvm.org
Wed Oct 23 02:12:45 PDT 2024
================
@@ -28,6 +29,123 @@ using namespace mlir;
#define DEBUG_TYPE "dlti"
+//===----------------------------------------------------------------------===//
+// parsing
+//===----------------------------------------------------------------------===//
+
+static ParseResult parseKeyValuePair(AsmParser &parser,
+ DataLayoutEntryInterface &entry,
+ bool tryType = false) {
+ Attribute value;
+
+ if (tryType) {
+ Type type;
+ OptionalParseResult parsedType = parser.parseOptionalType(type);
+ if (parsedType.has_value()) {
----------------
Dinistro wrote:
```suggestion
if (OptionalParseResult parsedType = parser.parseOptionalType(type);) {
```
Nit: Would this work?
https://github.com/llvm/llvm-project/pull/113365
More information about the Mlir-commits
mailing list