[Mlir-commits] [mlir] [mlir][transform] Overhaul `RegionBranchOpInterface` implementations. (PR #111408)

[Ingo Müller]

================
@@ -104,16 +104,8 @@ transform::AlternativesOp::getEntrySuccessorOperands(RegionBranchPoint point) {
 
 void transform::AlternativesOp::getSuccessorRegions(
     RegionBranchPoint point, SmallVectorImpl<RegionSuccessor> &regions) {
-  for (Region &alternative : llvm::drop_begin(
----------------
ingomueller-net wrote:

For that line, I think the same applies as what I said about the other line: this constructs the `RegionSuccessor` with an empty `BlockArgListType` via a default argument of [this constructor](https://github.com/llvm/llvm-project/blob/d626f95564/mlir/include/mlir/Interfaces/ControlFlowInterfaces.h#L169). And I believe that that means "no arguments are passed" rather than "it isn't specified what arguments are passed."

https://github.com/llvm/llvm-project/pull/111408