[Mlir-commits] [mlir] [mlir][transform] Overhaul `RegionBranchOpInterface` implementations. (PR #111408)

Ingo Müller llvmlistbot at llvm.org
Thu Oct 10 04:49:59 PDT 2024


================
@@ -104,16 +104,8 @@ transform::AlternativesOp::getEntrySuccessorOperands(RegionBranchPoint point) {
 
 void transform::AlternativesOp::getSuccessorRegions(
     RegionBranchPoint point, SmallVectorImpl<RegionSuccessor> &regions) {
-  for (Region &alternative : llvm::drop_begin(
----------------
ingomueller-net wrote:

I am not sure I understand what you mean. AFAIU, `RegionSuccessor()` creates a `RegionSuccessor` that `isParent`, i.e., the function indicates that the region may give control flow back to the parent op. The fact that there are no arguments provided means that it gives the control back with passing results on the way. That's different from not saying which arguments it passes, no?

https://github.com/llvm/llvm-project/pull/111408


More information about the Mlir-commits mailing list