[Mlir-commits] [mlir] [mlir][Transforms] Add 1:N `matchAndRewrite` overload (PR #116470)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-out-of-tree` running on `linaro-flang-aarch64-out-of-tree` while building `mlir` at step 7 "build-flang-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/53/builds/8746

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-flang-unified-tree) failure: build (failure)
0.298 [72/3/1] Generating VCSVersion.inc
33.054 [72/2/2] Building CXX object lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/BoxedProcedure.cpp.o
35.239 [66/7/3] Building CXX object lib/Common/CMakeFiles/FortranCommon.dir/Version.cpp.o
62.595 [66/6/4] Building CXX object lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/PreCGRewrite.cpp.o
63.210 [66/5/5] Building CXX object lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o
FAILED: lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_flang/lib/Optimizer/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/lib/Optimizer/CodeGen -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_flang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/tools/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/clang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/build_llvm/tools/clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17   -D_GNU_SOURCE -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o -MF lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o.d -o lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-out-of-tree/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp
In file included from ../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
../llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::AddrOfOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  228 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,
      |                ^
../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:136:36: note: in instantiation of template class 'fir::FIROpConversion<fir::AddrOfOp>' requested here
  136 | struct AddrOfOpConversion : public fir::FIROpConversion<fir::AddrOfOp> {
      |                                    ^
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::AddrOfOp')
  541 |   virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
      |                ^
In file included from ../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
../llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::cg::XDeclareOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  228 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,
      |                ^
../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:197:37: note: in instantiation of template class 'fir::FIROpConversion<fir::cg::XDeclareOp>' requested here
  197 | struct DeclareOpConversion : public fir::FIROpConversion<fir::cg::XDeclareOp> {
      |                                     ^
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::cg::XDeclareOp')
  541 |   virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
      |                ^
In file included from ../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
../llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::AllocaOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  228 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,
      |                ^
../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:220:36: note: in instantiation of template class 'fir::FIROpConversion<fir::AllocaOp>' requested here
  220 | struct AllocaOpConversion : public fir::FIROpConversion<fir::AllocaOp> {
      |                                    ^
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::AllocaOp')
  541 |   virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
      |                ^
In file included from ../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
../llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::BoxAddrOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  228 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,
      |                ^
../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:325:37: note: in instantiation of template class 'fir::FIROpConversion<fir::BoxAddrOp>' requested here
  325 | struct BoxAddrOpConversion : public fir::FIROpConversion<fir::BoxAddrOp> {
      |                                     ^
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::BoxAddrOp')
  541 |   virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
      |                ^
In file included from ../llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
../llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::BoxCharLenOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  228 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,

```

</details>

https://github.com/llvm/llvm-project/pull/116470