[Mlir-commits] [mlir] [mlir][Transforms] Add 1:N `matchAndRewrite` overload (PR #116470)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/14072

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
57.330 [218/83/6365] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.16.cpp.o
57.355 [218/82/6366] Building CXX object tools/mlir/lib/Conversion/AMDGPUToROCDL/CMakeFiles/obj.MLIRAMDGPUToROCDL.dir/AMDGPUToROCDL.cpp.o
57.377 [217/82/6367] Linking CXX static library lib/libMLIRAMDGPUToROCDL.a
57.583 [217/81/6368] Linking CXX executable bin/clang-linker-wrapper
57.797 [217/80/6369] Building CXX object tools/mlir/lib/Conversion/MathToLLVM/CMakeFiles/obj.MLIRMathToLLVM.dir/MathToLLVM.cpp.o
57.816 [216/80/6370] Linking CXX static library lib/libMLIRMathToLLVM.a
57.819 [216/79/6371] Building CXX object tools/mlir/lib/Dialect/Math/Transforms/CMakeFiles/obj.MLIRMathTransforms.dir/PolynomialApproximation.cpp.o
57.848 [215/79/6372] Linking CXX static library lib/libMLIRMathTransforms.a
57.854 [214/79/6373] Building CXX object tools/mlir/lib/Dialect/SparseTensor/Transforms/CMakeFiles/obj.MLIRSparseTensorTransforms.dir/SparseTensorRewriting.cpp.o
57.870 [214/78/6374] Building CXX object tools/flang/lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o
FAILED: tools/flang/lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o 
ccache /home/buildbots/llvm-external-buildbots/clang.16.0.1/bin/clang++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/lib/Optimizer/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/flang/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/include -isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../mlir/include -isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/mlir/include -isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/build/tools/clang/include -isystem /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/flang/lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o -MF tools/flang/lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o.d -o tools/flang/lib/Optimizer/CodeGen/CMakeFiles/FIRCodeGen.dir/CodeGen.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::AddrOfOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  virtual void rewrite(SourceOp op, OpAdaptor adaptor,
               ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:136:36: note: in instantiation of template class 'fir::FIROpConversion<fir::AddrOfOp>' requested here
struct AddrOfOpConversion : public fir::FIROpConversion<fir::AddrOfOp> {
                                   ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::AddrOfOp')
  virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
               ^
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::cg::XDeclareOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  virtual void rewrite(SourceOp op, OpAdaptor adaptor,
               ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:197:37: note: in instantiation of template class 'fir::FIROpConversion<fir::cg::XDeclareOp>' requested here
struct DeclareOpConversion : public fir::FIROpConversion<fir::cg::XDeclareOp> {
                                    ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::cg::XDeclareOp')
  virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
               ^
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::AllocaOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  virtual void rewrite(SourceOp op, OpAdaptor adaptor,
               ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:220:36: note: in instantiation of template class 'fir::FIROpConversion<fir::AllocaOp>' requested here
struct AllocaOpConversion : public fir::FIROpConversion<fir::AllocaOp> {
                                   ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/llvm/../mlir/include/mlir/Transforms/DialectConversion.h:541:16: note: hidden overloaded virtual function 'mlir::ConversionPattern::rewrite' declared here: type mismatch at 1st parameter ('Operation *' vs 'fir::AllocaOp')
  virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
               ^
In file included from /home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:17:
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/include/flang/Optimizer/CodeGen/FIROpPatterns.h:228:16: error: 'fir::FIROpConversion<fir::BoxAddrOp>::rewrite' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
  virtual void rewrite(SourceOp op, OpAdaptor adaptor,
               ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-flang-rhel-test/ppc64le-flang-rhel-clang-build/llvm-project/flang/lib/Optimizer/CodeGen/CodeGen.cpp:325:37: note: in instantiation of template class 'fir::FIROpConversion<fir::BoxAddrOp>' requested here
struct BoxAddrOpConversion : public fir::FIROpConversion<fir::BoxAddrOp> {
                                    ^

```

</details>

https://github.com/llvm/llvm-project/pull/116470