[Mlir-commits] [mlir] [mlir][linalg] Introduce new `linalg.conv` op (PR #117688)

[Renato Golin]

rengolin wrote:

In the original thread, there were a lot of different views. Because this is not a trivial change, we need to make sure all those views were taken into account. It's not clear that it has, since the people involved in the original discussion were not aware of this PR.

I welcome and encourage the enthusiasm of working in various areas of LLVM, but we should not start pushing code upstream that has not been shown to go in the right direction. That'll need buy-in from all parties.

I'm hoping we can use this PR to hash that out, but the number of missing things and "room for improvement" tells me it will not be easy.

In the future, for large changes like this, I strongly encourage you to work with the people who expressed concerns in the RFC _before_ you push a PR. It saves us all the trouble of yet-another discussion that has no conclusion.

@banach-space @MaheshRavishankar @javedabsar1 @rolfmorel 

https://github.com/llvm/llvm-project/pull/117688