[Mlir-commits] [mlir] [MLIR][Arith] SelectOp fix invalid folding (PR #117555)

[Jakub Kuderski]

kuhar wrote:

> > We should add a LIT test for the case that used to fail.
> 
> I agree, but at first glance, I couldn't find an upstream MLIR dialect that supports unsigned/signed constants to trigger this bug. But I might have missed a suitable dialect.

I don't think the condition has to be a constant, can we use a signed function argument instead or a result of an unregistered op?

https://github.com/llvm/llvm-project/pull/117555