[Mlir-commits] [mlir] [MLIR][Arith] SelectOp fix invalid folding (PR #117555)

[llvmlistbot at llvm.org]

7FM wrote:

> > The pattern select %x, true, false => %x is only valid in case that the return type is identical to the type of %x (i.e., i1). Hence, the check isInteger(1) was replaced with isSignlessInteger(1).
> 
> Can we still replace by a bitcast when the types are different?

`error: 'arith.bitcast' op result #0 must be signless-integer-or-float-like or memref of signless-integer or float, but got 'ui1'`
I don't think so, at least not without further modifications.

https://github.com/llvm/llvm-project/pull/117555